Re: [[PATCH v6] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.06.2015 10:21, Vasiliy Tolstov wrote:
> If a user specify ehernet device create it via libvirt and run
> script if it provided. After this commit user does not need to
> run external script to create tap device or add root to qemu
> process.
> 
> Signed-off-by: Vasiliy Tolstov <v.tolstov@xxxxxxxxx>
> ---
>  src/qemu/qemu_command.c | 142 +++++++++++++++++++++++++++++++-----------------
>  src/qemu/qemu_hotplug.c |  13 ++---
>  src/qemu/qemu_process.c |   6 ++
>  3 files changed, 101 insertions(+), 60 deletions(-)
> 

Just a couple of my findings:

- this is not rebased onto the HEAD from the date you've sent this
- 'make check' is broken with this patch applied. I'm tracing it down,
to see how many functions do we need to mock.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]