On 06/15/2015 03:47 PM, Peter Krempa wrote: > If @flags contains only VIR_DOMAIN_AFFECT_CONFIG and @vm is active, the > function would return the active config rather than the persistent one > that it should return. This happened due to the fact that > virDomainObjGetDefs was checking the updated flags which may not contain > VIR_DOMAIN_AFFECT_LIVE if it is not requested even if @vm is active. > > Additionally the function would not take the flags into account when > setting the pointers which was later used to determine whether the code > needs to update the given configuration. > > The mistake was caught by the virt-test suite. > --- > Version 2 actually fixes the function. > > src/conf/domain_conf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > ACK John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list