On Tue, Jun 16, 2015 at 11:16:03AM +0200, Cédric Bosdonnat wrote: > Let the user specify the format of the source disk image in host-image > mounts. This will allow us to mount other image types than raw ones. > --- > .../libvirt-sandbox-builder-container.c | 10 +++ > libvirt-sandbox/libvirt-sandbox-builder-machine.c | 9 +++ > .../libvirt-sandbox-config-mount-host-image.c | 91 +++++++++++++++++++++- > .../libvirt-sandbox-config-mount-host-image.h | 5 +- > libvirt-sandbox/libvirt-sandbox-config.c | 68 +++++++++++++++- > libvirt-sandbox/libvirt-sandbox.sym | 5 ++ > libvirt-sandbox/tests/test-config.c | 1 + > 7 files changed, 181 insertions(+), 8 deletions(-) > diff --git a/libvirt-sandbox/libvirt-sandbox-config-mount-host-image.h b/libvirt-sandbox/libvirt-sandbox-config-mount-host-image.h > index 228c459..95ec05e 100644 > --- a/libvirt-sandbox/libvirt-sandbox-config-mount-host-image.h > +++ b/libvirt-sandbox/libvirt-sandbox-config-mount-host-image.h > @@ -59,7 +59,10 @@ struct _GVirSandboxConfigMountHostImageClass > GType gvir_sandbox_config_mount_host_image_get_type(void); > > GVirSandboxConfigMountHostImage *gvir_sandbox_config_mount_host_image_new(const gchar *source, > - const gchar *targetdir); > + const gchar *targetdir, > + GVirConfigDomainDiskFormat format); This breaks ABI compatibility, which is fine since we're not yet promising stability, but we must change LIBVIRT_SANDBOX_SONUM in configure.ac too when breaking ABI. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list