Re: [PATCH v3 19/24] qemu_monitor: Wire up MIGRATION event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 10, 2015 at 15:42:53 +0200, Jiri Denemark wrote:
> Thanks to Juan's work QEMU finally emits an event whenever migration
> state changes.
> 
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
> 
> Notes:
>     The MIGRATION event is not supported by QEMU yet, this patch is based
>     on the current patches available on qemu-devel mailing list. However,
>     there were no objections to the design of the event, which makes it
>     unlikely to change. Anyway this will have to wait until the patches
>     are applied to QEMU.
>     
>     ACKed in version 2
>     
>     Version 3:
>     - rebased (context conflict in qemu_capabilities.[ch])
>     
>     Version 2:
>     - new patch
> 
>  src/qemu/qemu_capabilities.c |  3 +++
>  src/qemu/qemu_capabilities.h |  1 +
>  src/qemu/qemu_monitor.c      | 14 ++++++++++++++
>  src/qemu/qemu_monitor.h      |  8 ++++++++
>  src/qemu/qemu_monitor_json.c | 23 +++++++++++++++++++++++
>  5 files changed, 49 insertions(+)

...

> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index b5a7770..34cd078 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -229,6 +229,7 @@ typedef enum {
>      QEMU_CAPS_DEA_KEY_WRAP       = 187, /* -machine dea_key_wrap */
>      QEMU_CAPS_DEVICE_PCI_SERIAL  = 188, /* -device pci-serial */
>      QEMU_CAPS_CPU_AARCH64_OFF    = 189, /* -cpu ...,aarch64=off */
> +    QEMU_CAPS_MIGRATION_EVENT	 = 190, /* MIGRATION event */

The alignment of the equals sign is off here.

>  
>      QEMU_CAPS_LAST,                   /* this must always be the last item */
>  } virQEMUCapsFlags;

ACK with that fixed.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]