On Wed, Jun 10, 2015 at 03:13:15PM +0200, Cedric Bosdonnat wrote: > On Wed, 2015-06-10 at 13:06 +0100, Daniel P. Berrange wrote: > > On Wed, Jun 10, 2015 at 01:40:07PM +0200, Eren Yagdiran wrote: > > > Hello, > > > > > > These patches provide disk support for libvirt-sandbox. > > > Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. > > > Currently, we only support qcow2 file format and fallback is set to RAW type. > > > > Can you explain a bit more why you need to be able to expose a virtual > > disk to the sandbox. If the stuff running inside the sandbox is not > > privileged, it won't even have access to the device node inside it, > > nor be able to mount it. This is why the sandbox code focuses on > > mounting everything itself before handing off the main app to run. > > So I'm not really clear how this feature is going to be generally > > useful or usable. > > Before filling the qcow2 images, we need to be able to format them... > would you then suggest to manually setup the nbd device, and run mkfs on > it? I was thinking about having that done through virt-sandbox... Ah ha, ok, that makes some sense now. So this isn't really for the purpose of executing docker images - its for the earlier step where we actually turn the downloaded docker images into something we can run. This stage of the process would be running privileged, so it makes sense it can use a block device. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list