Re: [PATCH 0/2] Fix network names with quotes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01.06.2015 10:06, Shivaprasad G Bhat wrote:
> The following series implements...
> 
> ---
> 
> Shivaprasad G Bhat (2):
>       fix domaincommon.rng to accept network name with quotes
>       escape quotes for dsmasq conf contents
> 
> 
>  docs/schemas/domaincommon.rng                      |    2 +-
>  src/util/virdnsmasq.c                              |   25 +++++++++++++++----
>  src/util/virpidfile.c                              |   15 ++++++++----
>  .../nat-network-name-with-quotes.conf              |   20 +++++++++++++++
>  .../nat-network-name-with-quotes.xml               |   26 ++++++++++++++++++++
>  tests/networkxml2conftest.c                        |    1 +
>  6 files changed, 79 insertions(+), 10 deletions(-)
>  create mode 100644 tests/networkxml2confdata/nat-network-name-with-quotes.conf
>  create mode 100644 tests/networkxml2confdata/nat-network-name-with-quotes.xml
> 


There's nothing wrong with the patches. I'm just curious, what's the use
case? I always thought that name should be something simple. On the
other hand, we do something similar with domain names IIRC.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]