Re: [PATCH v3 3/4] conf: storage: Don't emit empty <permissions> block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/24/2015 07:38 AM, John Ferlan wrote:
> 
> 
> On 05/21/2015 04:03 PM, Cole Robinson wrote:
>> ---
>> v3:
>>     New patch
>>
>>  src/conf/storage_conf.c                            | 42 +++++++++++++---------
>>  tests/storagepoolxml2xmlout/pool-netfs-gluster.xml |  2 --
>>  tests/storagevolxml2xmlout/vol-gluster-dir.xml     |  2 --
>>  tests/storagevolxml2xmlout/vol-sheepdog.xml        |  2 --
>>  4 files changed, 26 insertions(+), 22 deletions(-)
>>
> 
> ACK - although I suppose it could be combined with 2/4, but I'm OK with
> it being separate.
> 

I intentionally kept them separate since I didn't want to mix up functional
changes with a cosmetic output change.

Pushed this and patch #4 as is. Thanks for the review!

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]