On 05/13/2015 12:32 PM, John Ferlan wrote:
> To silence Coverity just add a 'p &&' in front of the check in
> networkFindUnusedBridgeName after the strchr() call. Even though
> we know it's not possible to have strchr return NULL since the only
> way into the function is if there is a '%' in def->bridge or it's NULL.
Agreed (I hand traced all the possible combinations to be sure), and ACK.
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
> src/network/bridge_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index 4b53475..f438c0b 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -2780,7 +2780,7 @@ networkFindUnusedBridgeName(virNetworkObjListPtr nets,
>
> if (def->bridge &&
> (p = strchr(def->bridge, '%')) == strrchr(def->bridge, '%') &&
> - p[1] == 'd')
> + p && p[1] == 'd')
> templ = def->bridge;
>
> do {
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list