Changes from v1: * remove vshControl parameter from vshCommandOpt(), as suggested by Peter * document @ctl parameter for all other functions * update vshCommandOptScaledInt(), which I had missed the first time Cheers. Andrea Bolognani (3): virsh: Make vshCommandOptScaledInt() use vshCommandOpt(). virsh: Pass vshControl to all vshCommandOpt*() calls. virsh: Move error messages inside vshCommandOpt*() functions. tests/vcpupin | 4 +- tools/virsh-domain-monitor.c | 97 +++--- tools/virsh-domain.c | 696 +++++++++++++++++++------------------------ tools/virsh-host.c | 87 ++---- tools/virsh-interface.c | 18 +- tools/virsh-network.c | 38 ++- tools/virsh-nodedev.c | 6 +- tools/virsh-pool.c | 26 +- tools/virsh-secret.c | 8 +- tools/virsh-snapshot.c | 88 +++--- tools/virsh-volume.c | 50 ++-- tools/virsh.c | 217 ++++++++------ tools/virsh.h | 77 ++--- 13 files changed, 645 insertions(+), 767 deletions(-) -- 2.1.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list