Re: [PATCH 1/2] virDomainNumatuneGetMode: Report if numatune was defined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 19, 2015 at 01:33:10PM +0200, Michal Privoznik wrote:
So far, we are not reporting if numatune was even defined. The
value of zero is blindly returned (which maps onto
VIR_DOMAIN_NUMATUNE_MEM_STRICT). Unfortunately, we are making
decisions based on this value. Instead, we should not inly return

s/inli/only/

the correct value, but report to the caller if the value is valid
at all.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---

Notes:
   I know, qemuDomainGetNumaParameters() is not fixed yet, that's what the very
   next patch does.  For better view on this patch use --ignore-space-change.


I like mentioning the usability of "-w" diff flag in the commit
message, that way it's visible for people going through the history.

Anyway, ACK.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]