On Mon, Jan 19, 2009 at 03:14:19PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > > The 'inotify' driver currently keeps all its state in a global static > > variables. Not so great since we access this from all sorts of places > > and its hard to guarentee thread safety. Also, we're using per-connection > > FD watches to update this state, so if multiple Xen connections were > > active, they'd all be updating the same globl state. So we move the > > state into the virConnect object. This will increase memory usage if > > a single process has multiple Xen connections open though, but not > > by very much > > Looks fine. > ACK Comitted this. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list