On 05/15/2015 12:52 PM, Jim Fehlig wrote:
> Currently, the libxl driver does not support any security drivers.
> When the qemu driver has no security driver configued,
> nodeGetSecurityModel succeeds but returns an empty virSecurityModel
> object. Do the same in the libxl driver instead of reporting
>
> this function is not supported by the connection driver:
> virNodeGetSecurityModel
>
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
>
> I was reminded of this today when looking through a libvirtd log.
> The system was running a test script that among other things
> called 'virsh dominfo'. Each time dominfo was called, the log
> was spammed with "this function is not supported by the connection
> driver: virNodeGetSecurityModel".
>
> src/libxl/libxl_driver.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index 60c139e..d6b20ae 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -5027,6 +5027,23 @@ libxlDomainMigrateConfirm3Params(virDomainPtr domain,
> return libxlDomainMigrationConfirm(driver, vm, flags, cancelled);
> }
>
> +static int libxlNodeGetSecurityModel(virConnectPtr conn,
> + virSecurityModelPtr secmodel)
> +{
> + memset(secmodel, 0, sizeof(*secmodel));
I wonder if src/libvirt-host.c should take care of this for all callers.
But it doesn't need to happen in this patch.
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list