On Tue, May 12, 2015 at 02:37:09PM +0200, Jiri Denemark wrote:
> Instead of redoing the same filtering over and over everytime we need to
> walk through all disks which are being migrated.
>
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
> src/conf/domain_conf.h | 2 ++
> src/qemu/qemu_migration.c | 23 ++++++-----------------
> 2 files changed, 8 insertions(+), 17 deletions(-)
>
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 2cd105a7..391f49a 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -703,6 +703,8 @@ struct _virDomainDiskDef {
> int blockJobStatus; /* status of the finished block job */
> bool blockJobSync; /* the block job needs synchronized termination */
>
> + bool migrating; /* the disk is being migrated */
I'm not a huge fan of the fact that we're filling the generic
virDomainDiskDef struct with ever more QEMU driver state fields.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list