Re: [PATCH v2 3/5] storage: conf: Don't set any default <mode> in the XML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/08/2015 08:24 AM, John Ferlan wrote:

> 
> I think right about here there needs to be some logic added to avoid
> printing (since it's optional anyway):
> 
> <permissions>
> </permissions>
> 
> in the output XML

We may still want to output:

<permissions/>

to make it obvious that we considered permissions, but had nothing to
say about them (as opposed to no information about it at all) - similar
to how <backingChain/> is used in <disk> elements to distinguish between
end-of-chain and no information available.

But I agree that an empty

<permissions>
</permissions>

looks weird, even though it is equally valid as XML.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]