Re: [PATCH] maint: increase stack frame size limit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/03/2015 10:22 AM, Roman Bogorodskiy wrote:
> Currently the stack frame size limit is set to 4096 and it started to
> cause an error like this:
> 
> virshtest.c:253:1: error: stack frame size of 5512 bytes in function
> 'mymain' [-Werror,-Wframe-larger-than=]
> mymain(void)
> ^
> 1 error generated.
> 
> Increase it to 6144.

NACK.  4096 is there for a reason; we do NOT want to exceed a page size.
 Instead, we need to fix virshtest.c to quit stack-allocating such a
large structure.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]