Re: [PATCH] tests: Remove redundant aarch64 tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/07/2015 11:30 AM, Cole Robinson wrote:
> My commit 7b9de914 added some aarch64 CPU test cases. I wanted to test
> two different code paths but inadvertently added two of the same test
> cases.
>
> The second code path (using <cpu><model>host</model</cpu>) isn't easily
> exercised via the qemu tests anyways, I'll need to look elsewhere.
>
> Regardless, remove the redundant tests for now
> ---
>  .../qemuxml2argv-aarch64-cpu-model-host.args       |  5 ----
>  .../qemuxml2argv-aarch64-cpu-model-host.xml        | 28 ----------------------
>  tests/qemuxml2argvtest.c                           |  3 ---
>  .../qemuxml2argv-aarch64-cpu-passthrough.xml       | 27 ---------------------
>  tests/qemuxml2xmltest.c                            |  2 --
>  5 files changed, 65 deletions(-)
>  delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.args
>  delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.xml
>  delete mode 100644 tests/qemuxml2xmloutdata/qemuxml2argv-aarch64-cpu-passthrough.xml

You also delete a redundant xml file in qemuxml2xmloutdata (since it's
identical to the file in qemuxml2argvdata).


ACK.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]