Olaf Hering wrote:
> Both attach and detach functions get called only if the type matches.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
> src/libxl/libxl_driver.c | 6 ------
> 1 file changed, 6 deletions(-)
>
ACK. I think callers will always check the hostdev's subsys->type,
calling the appropriate libxlDomain{Attach,Detach}Host<type>Device()
function, so agreed there is no need to check it again.
I've pushed this one too. Thanks!
Regards,
Jim
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index d76efda..f915f91 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -2901,9 +2901,6 @@ libxlDomainAttachHostPCIDevice(libxlDriverPrivatePtr driver,
>
> libxl_device_pci_init(&pcidev);
>
> - if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
> - goto cleanup;
> -
> if (virDomainHostdevFind(vm->def, hostdev, &found) >= 0) {
> virReportError(VIR_ERR_OPERATION_FAILED,
> _("target pci device %.4x:%.2x:%.2x.%.1x already exists"),
> @@ -3239,9 +3236,6 @@ libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr driver,
>
> libxl_device_pci_init(&pcidev);
>
> - if (subsys->type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
> - goto cleanup;
> -
> idx = virDomainHostdevFind(vm->def, hostdev, &detach);
> if (idx < 0) {
> virReportError(VIR_ERR_OPERATION_FAILED,
>
>
>
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list