Re: [PATCH] virNetSocketNewConnectUNIX: Don't unlink(NULL)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/16/2015 10:28 AM, Michal Privoznik wrote:
> There is a possibility that we jump onto error label with @lockpath
> still initialized to NULL. Here, the @lockpath should be unlink()-ed,
> but passing there a NULL is not a good idea. Don't do that. In fact,
> we should call unlink() only if we created the lock file successfully.
> 
> Reported-by: John Ferlan <jferlan@xxxxxxxxxx>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/rpc/virnetsocket.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
ACK  (Coverity is happy too)

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]