Re: [PATCH v2 1/8] storage: Refactor iSCSI Source matching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 13, 2015 at 17:21:05 -0400, John Ferlan wrote:
> Create a separate iSCSI Source matching subroutine. Makes the calling
> code a bit cleaner as well as sets up for future patches which need to
> do better source hosts[0].name processing/checking.
> 
> As part of the effort the logic will be inverted from a multi-level
> if statement to a series of single level checks for better readability
> and further separation
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>

Double sign-off.

> ---
>  src/conf/storage_conf.c | 33 ++++++++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 11 deletions(-)a

ACK, it looks much better now.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]