On Mon, Apr 13, 2015 at 15:35:46 -0400, John Ferlan wrote: > > > On 04/13/2015 05:27 AM, Peter Krempa wrote: > > On Thu, Apr 02, 2015 at 13:39:38 -0400, John Ferlan wrote: > >> Create a separate iSCSI Source matching subroutine. Makes the calling > >> code a bit cleaner as well as sets up for future patches which need to > >> do better source hosts[0].name processing/checking > >> > >> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > >> --- > >> src/conf/storage_conf.c | 35 ++++++++++++++++++++++++----------- > >> 1 file changed, 24 insertions(+), 11 deletions(-) > >> > >> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c > >> index 8b1898b..4a38416 100644 > >> --- a/src/conf/storage_conf.c > >> +++ b/src/conf/storage_conf.c > >> @@ -2291,6 +2291,28 @@ matchSCSIAdapterParent(virStoragePoolObjPtr pool, > >> } > >> > >> > >> +static bool > >> +matchISCSISource(virStoragePoolObjPtr matchpool, > > > > Please use the virStorageConf... prefix for the new function. > > > > How about "virStoragePoolSourceISCSIMatch" Sounds good to me. Peter
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list