Re: [PATCH 1/2] virBitmap: Place virBitmapIsAllClear check after virBitmapParse calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 10, 2015 at 12:41:12 +0200, Erik Skultety wrote:
> This patch adds checks for empty bitmaps right after the calls of
> virBitmapParse. These only include spots where set API's are called and
> where domain's XML is parsed.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1210545
> ---
>  src/conf/domain_conf.c   | 35 +++++++++++++++++++++++++++++++----
>  src/conf/numa_conf.c     | 23 +++++++++++++++++++----
>  src/qemu/qemu_driver.c   |  5 +++--
>  src/xenconfig/xen_sxpr.c |  7 +++++++
>  4 files changed, 60 insertions(+), 10 deletions(-)

I've "git grep"'d a few uses of this function and found a few places
that would also need a chceck. Few examples are the XML parser for
networks, the use in qemuProcessStart() to parse the automatic
placemenet and so on ..

The rest looks good though.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]