https://bugzilla.redhat.com/show_bug.cgi?id=980327 First ten patches contain no functional change. Patches 11 and 12 potentially change the default qcow2 compatibility level. The last patch contains the proposed XML. Ján Tomko (13): Visually separate snapshot disk subelements Remove feature formating funcs from pool-specific options Separate out virStorageFeatureParse Separate virStorageFeatureFormat Split out storage format 'compat' attribute sanity check Use XPath when parsing snapshot disk definition Rename virStorageBackendCreateQemuImgCmd Introduce struct _virStorageBackendQemuImgInfo Split out qemu-img command generation Remove overengineered loop Use qemu-img to precreate the qcow2 disks Rework qemu-img command generation for inactive external snapshots Add qcow2 features to snapshot XML docs/formatsnapshot.html.in | 50 ++- docs/schemas/domainsnapshot.rng | 10 +- po/POTFILES.in | 1 + src/Makefile.am | 5 + src/conf/snapshot_conf.c | 58 ++-- src/conf/storage_conf.c | 83 +---- src/conf/storage_feature_conf.c | 87 +++++ src/conf/storage_feature_conf.h | 25 ++ src/qemu/qemu_driver.c | 57 ++-- src/storage/storage_backend.c | 376 +++++++++++++-------- src/storage/storage_backend.h | 19 +- src/storage/storage_driver.c | 27 ++ src/storage/storage_driver.h | 4 + src/util/virstoragefile.c | 29 ++ src/util/virstoragefile.h | 1 + .../disk_snapshot_features.xml | 30 ++ .../disk_snapshot_features.xml | 30 ++ tests/domainsnapshotxml2xmltest.c | 2 + tests/storagevolxml2argvtest.c | 5 +- 19 files changed, 589 insertions(+), 310 deletions(-) create mode 100644 src/conf/storage_feature_conf.c create mode 100644 src/conf/storage_feature_conf.h create mode 100644 tests/domainsnapshotxml2xmlin/disk_snapshot_features.xml create mode 100644 tests/domainsnapshotxml2xmlout/disk_snapshot_features.xml -- 2.0.5 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list