Re: [PATCH v2 2/6] iscsi: Fix exit path for virStorageBackendISCSIFindLUs failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 01, 2015 at 01:29:07PM -0400, John Ferlan wrote:
> If the call to virStorageBackendISCSIGetHostNumber failed, we set
> retval = -1, but yet still called virStorageBackendSCSIFindLUs.
> Need to add a goto cleanup - while at it, adjust the logic to
> initialize retval to -1 and only changed to 0 (zero) on success.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/storage/storage_backend_iscsi.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

ACK

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]