On 03/31/2015 04:19 PM, Eric Blake wrote: > On 03/31/2015 09:19 AM, Cole Robinson wrote: >> On 03/31/2015 06:06 AM, Ján Tomko wrote: >>> On Sat, Mar 28, 2015 at 02:31:30PM -0400, Cole Robinson wrote: >>> -- 8< -- >>> >>> ACK to both. >>> >>> Jan >>> >> >> Thanks, but trying to push I'm getting errors: >> >> remote: tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent:1: new blank line >> at EOF. > > I'll push on your behalf (I know the magic secrets for temporarily > relaxing the libvirt.org commit checks in cases like this. Supposedly, > it was at one point possible for anyone to make those changes on a > one-push basis by creating a special tag for the commit, but without > actually reading the hooks on libvirt.org, and in light of no > documentation for such a hack, I think that the only people that can do > it right now are those with libvirt.org shell login; it would be nice to > get to a point where anyone with push rights could do it even without > shell rights, but it happens so seldom that no one is ever motivated to > tackle that project) > > >> And now that I actually run syntax-check (sorry), seeing an additional error: >> >> tests/nodeinfodata/linux-f21-mustang/cpu/offline:1: >> tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/offline:1: >> maint.mk: Prohibited empty first line >> cfg.mk:956: recipe for target 'sc_prohibit_empty_first_line' failed >> make: *** [sc_prohibit_empty_first_line] Error 1 > > And the fix for this is: > > diff --git i/cfg.mk w/cfg.mk > index 661cccc..79c5d48 100644 > --- i/cfg.mk > +++ w/cfg.mk > @@ -1185,7 +1185,7 @@ > exclude_file_name_regexp--sc_prohibit_mixed_case_abbreviations = \ > > ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.c)$$ > > exclude_file_name_regexp--sc_prohibit_empty_first_line = \ > - > ^(README|daemon/THREADS\.txt|src/esx/README|docs/library.xen|tests/vmwareverdata/fusion-5.0.3.txt|tests/nodeinfodata/linux-raspberrypi/cpu/offline)$$ > + > ^(README|daemon/THREADS\.txt|src/esx/README|docs/library.xen|tests/(vmware|nodeinfo)data/*)$$ > > exclude_file_name_regexp--sc_prohibit_useless_translation = \ > ^tests/virpolkittest.c > > >> >> >> I attached the unaltered patches if anyone wants to figure out the tweaks to >> make these bits pass, I can't look at this at the moment. > > I'll push shortly. > Thanks a lot Eric! - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list