Re: [PATCH] virDomainShutdown*: Describe blocking behaviour

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/31/2015 01:37 AM, Michal Privoznik wrote:

>> I don't think this is the right approach.  It is okay to block for a
>> small finite amount of time, but if the guest agent really is something
>> that can hang, we should fix that code to return without waiting for the
>> agent response.
>>
> 
> The problem is, we can tell if the shutdown qemu-ga command succeeded
> only when we see the SHUTDOWN event on the domain monitor.

But we don't NEED to know if it succeeded - per our docs, we only issue
the request (or fail outright because the request cannot be delivered
because the agent is non-responsive).

> The other
> option is to treat it like we're treating ACPI mode of the API: just
> send the request and report if the sending succeeded. Don't wait until
> domain actually shuts down. I can provide a patch.

Yes, that would be more in line with the docs.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]