Re: [PATCH 1/3] qemu: processBlockJob: Don't unlock @vm twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/30/2015 03:26 AM, Peter Krempa wrote:
> Commit 1a92c719 moved code to handle block job events to a different
> function that is executed in a separate thread. The caller of
> processBlockJob handles locking and unlocking of @vm, so the we should
> not do it in the function itself.
> ---
>  src/qemu/qemu_driver.c | 1 -
>  1 file changed, 1 deletion(-)

ACK; bug fix so safe for freeze.

> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index f07e4fb..f1cbc46 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4574,7 +4574,6 @@ processBlockJobEvent(virQEMUDriverPtr driver,
>              VIR_WARN("Unable to update persistent definition on vm %s "
>                       "after block job", vm->def->name);
>      }
> -    virObjectUnlock(vm);
>      virObjectUnref(cfg);
> 
>      if (event)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]