On 03/30/2015 09:41 AM, Peter Krempa wrote: > The block copy API takes the speed in bytes/s rather than MiB/s that was > the prior approach in virDomainBlockRebase. We correctly converted the > speed to bytes/s in the old API but we still called the common helper > virDomainBlockCopyCommon with the unadjusted variable. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1207122 > --- > src/qemu/qemu_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) D'oh on my part. Probably snuck in while I was rebasing across several different attempts for the best normalization approach. ACK. > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 4d05221..6700fc9 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -16811,7 +16811,7 @@ qemuDomainBlockRebase(virDomainPtr dom, const char *path, const char *base, > flags &= (VIR_DOMAIN_BLOCK_REBASE_SHALLOW | > VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT); > ret = qemuDomainBlockCopyCommon(vm, dom->conn, path, dest, > - bandwidth, 0, 0, flags, true); > + speed, 0, 0, flags, true); > dest = NULL; > > cleanup: > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list