Re: [PATCH 2/1] vircgroup: Fix build issue mingw cross compile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/27/2015 10:41 AM, John Ferlan wrote:
> Commit id '2dbfa716' exposed virCgroupDetectMountsFromFile, but did not
> add the corresponding entry in the "#else /* !VIR_CGROUP_SUPPORTED */"
> section of the module.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/util/vircgroup.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

ACK for helping the issue. These two patches together fixed the build
for me.  Okay to leave them as separate patches, since they fix problems
introduced by different commits (and therefore might be backported at
different times).

But with this fixed, another build issue surfaces:

../../tools/virsh-domain-monitor.c: In function 'cmdDomIfAddr':
../../tools/virsh-domain-monitor.c:2233:17: error: expected identifier
or '(' before 'struct'
     const char *interface = NULL;
                 ^

'interface' is one of those black-listed terms that we should never use
in our code (because mingw headers pollute the namespace); we use
'iface' elsewhere.  We should really add a syntax check to avoid
re-introducing it all the time...


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]