Re: [PATCH] Document that USB hostdevs do not need nodeDettach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 24, 2015 at 05:03:08PM -0400, John Ferlan wrote:
> 
> 
> On 03/23/2015 01:16 PM, Ján Tomko wrote:
> > The virNodeDeviceDettach API only works on PCI devices.
> > 
> > Originally added by commit 10d3272e, but the API never
> > supported USB devices.
> > 
> > Reported by: Martin Polednik <mpolednik@xxxxxxxxxx>
> > ---
> >  docs/formatdomain.html.in | 19 +++++++++----------
> >  tools/virsh.pod           | 17 ++++++++---------
> >  2 files changed, 17 insertions(+), 19 deletions(-)
> > 
> 
> ACK -
> 
> Should we say to call virNodeDeviceDetachFlags instead of
> virNodeDeviceDettach?

That API requires the driver name (allowing vfio passthrough)
and does not have the typo.

I made the change and pushed the patch.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]