On 03/23/2015 03:43 PM, Laine Stump wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1125755 > > reported that a stray bridge device was left on the system when a > libvirt network failed to start due to an illegal iptables rule caused > by bad config. Apparently the reason this was happening was that > NetworkManager was noticing immediately when the bridge device was > created and automatically setting it IFF_UP. libvirt would then try to > setup the iptables rules, get an error back, and since libvirt had > never IFF_UPed the bridge, it didn't expect that it needed to set it > ~IFF_UP before deleting it during the cleanup process. But the > ioctl(SIOCBRDELBR) ioctl will fail to delete a bridge if it is IFF_UP. > > Since that bug was reported, NetworkManager has gotten a bit more > polite in this respect, but just in case something similar happens in > the future, this patch switches to using the netlink RTM_DELLINK > message to delete the bridge - unlike SIOCBRDELBR, it will delete the > requested bridge no matter what the setting of IFF_UP. > --- > src/util/virnetdevbridge.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > ACK - John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list