Re: [PATCH 7/6] qemu: move virDomainLiveConfigHelperMethod right after BeginJob

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 24, 2015 at 05:13:07PM +0100, Peter Krempa wrote:
> On Fri, Mar 20, 2015 at 15:58:56 +0100, Pavel Hrdina wrote:
> > We should call virDomainLiveConfigHelperMethod ASAP because this
> > function transfers VIR_DOMAIN_AFFECT_CURRENT to VIR_DOMAIN_AFFECT_LIVE
> > or VIR_DOMAIN_AFFECT_CONFIG.  All other additional checks for those two
> > flags should consider that the user give us VIR_DOMAIN_AFFECT_CURRENT.
> > 
> > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> > ---
> >  src/qemu/qemu_driver.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> ACK, although this should be 0.5/6 or 1.5/6. Basically just push this
> first.
> 
> Peter

Thanks for review, I'll push it shortly.

Pavel

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]