Re: [PATCH 4/6] qemu: check if domain is really active when do setvcpus with --live

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 20, 2015 at 15:39:02 +0100, Pavel Hrdina wrote:
> From: Luyao Huang <lhuang@xxxxxxxxxx>
> 
> Commit e105dc9 fix setting vcpus for offline domain, but forget check
> if vm is active when pass VIR_DOMAIN_AFFECT_LIVE flags.
> 
>  # virsh setvcpus test3 4 --live
>  error: Failed to create controller cpu for group: No such file or directory
> 
> Add a check if we pass VIR_DOMAIN_AFFECT_LIVE flags.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1204006
> 
> Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx>
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

NACK, after the virDomainLiveConfigHelperMethod gets moved, this is not
logner necessary as it contains the same code.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]