Re: [PATCHv3 00/12] Add support for memory hotplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 19, 2015 at 18:41:31 -0400, John Ferlan wrote:
> 
> 
> On 03/17/2015 10:19 AM, Peter Krempa wrote:
> > This version includes review feedback changes from John and also fixes the
> > <memory> element documentation and code that calculates it to support possible 
> > non-NUMA configs with memory hotplug if any hypervisor would support that in the
> > future.
> > 
> > Peter Krempa (12):
> >   qemu: monitor: Don't leak @props with non-JSON in qemuMonitorAddObject
> >   libxl: Refactor logic in domain post parse callback
> >   conf: Add support for parsing and formatting max memory and slot count
> >   qemu: Implement setup of memory hotplug parameters
> >   conf: Add device address type for dimm devices
> >   conf: Add interface to parse and format memory device information
> >   qemu: memdev: Add infrastructure to load memory device information
> >   qemu: migration: Forbid migration with memory modules lacking info
> >   qemu: add support for memory devices
> >   qemu: conf: Add support for memory device cold(un)plug
> >   qemu: Implement memory device hotplug
> >   qemu: Implement memory device hotunplug

...

> > 
> >  38 files changed, 1747 insertions(+), 31 deletions(-)
> >  create mode 100644 tests/domainschemadata/maxMemory.xml
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm.args
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm.xml
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nonuma.xml
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.args
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.xml
> > 
> 
> ACK series with adjustments noted in patches 9 & 11 and of course the
> assurance about patch 10.

I've fixed all the points and pushed the series.

Thanks for reviewing these unpleasant amounts of code.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]