Re: qemu_migration: Precreate missing storage breaks with network drives

[Nick Bartos <nick@xxxxxxxxxxxxxxx>]

Actually I messed that up slightly on the case.  My C is a bit rusty:

diff -U3 -r libvirt-1.2.13.orig/src/qemu/qemu_migration.c libvirt-1.2.13/src/qemu/qemu_migration.c

--- libvirt-1.2.13.orig/src/qemu/qemu_migration.c 2015-02-23 22:04:12.000000000 -0800

+++ libvirt-1.2.13/src/qemu/qemu_migration.c 2015-03-18 13:55:45.873322477 -0700

@@ -1507,9 +1507,12 @@

             flags |= VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA;

         break;

 

+    case VIR_STORAGE_TYPE_NETWORK:

+        ret = 0;

+        goto cleanup;

+        break;

     case VIR_STORAGE_TYPE_BLOCK:

     case VIR_STORAGE_TYPE_DIR:

-    case VIR_STORAGE_TYPE_NETWORK:

     case VIR_STORAGE_TYPE_NONE:

     case VIR_STORAGE_TYPE_LAST:

         virReportError(VIR_ERR_INTERNAL_ERROR,

On Wed, Mar 18, 2015 at 1:42 PM, Noel Burton-Krahn <noel@xxxxxxxxxxxxxxx> wrote:

Hi Michal,

We're testing libvirt-1.2.13 and found it failed to live migrate domains with attached network drives.  The change to libvirt was made in commit cf54c606, announced here:  https://www.redhat.com/archives/libvir-list/2014-November/msg01053.html

It's not necessary to precreate network drives.  They're created during nova live migration in openstack.  How about this patch?

diff -U3 -r libvirt-1.2.13.orig/src/qemu/qemu_migration.c libvirt-1.2.13/src/qemu/qemu_migration.c

--- libvirt-1.2.13.orig/src/qemu/qemu_migration.c 2015-02-23 22:04:12.000000000 -0800

+++ libvirt-1.2.13/src/qemu/qemu_migration.c 2015-03-18 12:18:14.137990147 -0700

@@ -1510,6 +1510,9 @@

     case VIR_STORAGE_TYPE_BLOCK:

     case VIR_STORAGE_TYPE_DIR:

     case VIR_STORAGE_TYPE_NETWORK:

+        ret = 0;

+        goto cleanup;

+        break;

     case VIR_STORAGE_TYPE_NONE:

     case VIR_STORAGE_TYPE_LAST:

         virReportError(VIR_ERR_INTERNAL_ERROR,

Cheers,

--

Noel Burton-Krahn

Sr, Distributed Systems Engineer

Piston Cloud Computing

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list