Re: [PATCH] doc: Fix doc for backingStore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Wed, Mar 18, 2015 at 6:22 PM, Eric Blake <eblake@xxxxxxxxxx> wrote:
On 03/18/2015 03:47 AM, Deepak Shetty wrote:
> I spent quite some time figuring that backingStore info
> isn't included in the dom xml, unless guest is up and
> running. Hopefully putting that in the doc should help.
>
> This patch adds that info to the doc.
>
> Signed-off-by: Deepak C Shetty <deepakcs@xxxxxxxxxx>
> ---
>  docs/formatdomain.html.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index ab51982..dfd4f3a 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -2113,7 +2113,9 @@
>          and only used for output to describe the detected backing chains.
>          <span class="since">Since 1.2.4</span>. An empty
>          <code>backingStore</code> element means the sibling source is
> -        self-contained and is not based on any backing store. The following
> +        self-contained and is not based on any backing store. Note that
> +        <code>backingStore</code> info is included in the output only when
> +        the guest is up and running, otherwise its not included. The

s/its/it's/

> following

We aim to fix that in the future (that is, eventually libvirt will track
backing information even for offline domains), but until that happens, I
can agree with documenting the limitation.  I will touch this up and
push it later today.

Thanks, I am sending another patch, with this fix and some more info
(about having backing file format in the snap metadata)

Pls include whichever you think is more appropraite.

thanx,
deepak
 

--
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]