Re: [PATCH] util: clean up #includes of virnetdevopenvswitch.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/17/2015 11:50 AM, Laine Stump wrote:
> virnetdevopenvswitch.h declares a few functions that can be called to
> add ports to and remove them from OVS bridges, and retrieve the
> migration data for a port. It does not contain any data definitions
> that are used by domain_conf.h. But for some reason, domain_conf.h
> virnetdevopenvswitch.h should be directly #including it. This adds a

That sentence didn't read well.  Maybe

But for some reason, domain_conf.h was directly #including
virnetdevopenvswitch.h.

> few lines to the project, but saves all the files that don't need it
> from the extra computing, and makes the dependencies more clear cut.
> ---
>  src/conf/domain_conf.h    | 1 -
>  src/lxc/lxc_driver.c      | 1 +
>  src/lxc/lxc_process.c     | 1 +
>  src/qemu/qemu_hotplug.c   | 1 +
>  src/qemu/qemu_migration.c | 3 ++-
>  src/qemu/qemu_process.c   | 1 +
>  6 files changed, 6 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]