john.levon@xxxxxxx wrote: > Fix activeDomainList handling In your eventual ChangeLog entry, please mention xsWatchList, too. > It must be NULLed out after free()ing. > > Signed-off-by: John Levon <john.levon@xxxxxxx> > > diff --git a/src/xs_internal.c b/src/xs_internal.c > --- a/src/xs_internal.c > +++ b/src/xs_internal.c > @@ -388,8 +388,10 @@ xenStoreClose(virConnectPtr conn) > } > > xenStoreWatchListFree(priv->xsWatchList); > + priv->xsWatchList = NULL; > #ifndef PROXY > xenUnifiedDomainInfoListFree(activeDomainList); > + activeDomainList = NULL; > #endif > if (priv->xshandle == NULL) > return(-1); Definitely good fixes. Otherwise we'd end up dereferencing freed pointers. However these conflict with Dan's recent changes, so you should wait to hear from him. -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list