Re: [PATCH 00/12] More cleanup from IOThreads changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 13, 2015 at 11:11:44PM -0400, John Ferlan wrote:
> During the review process a few things were pointed at as perhaps
> needing some adjustments based on what was done for IOThreads.
> Specifically a memory leak in PinVcpuFlags since PinIOThreads was
> just a copy of the Vcpu code and secondarily since the IOThreads
> code "reused" the virDomainVcpuPin* data structures and API's, those
> should change names to be more generic.
> 
> 
> John Ferlan (12):
>   qemu: Fix possible memory leak in qemuDomainPinVcpuFlags
>   Convert virDomainVcpuPinDefPtr to virDomainPinDefPtr
>   Convert virDomainPinDefPtr->vcpuid to virDomainPinDefPtr->id
>   Convert virDomainVcpuPinDefFree to virDomainPinDefFree
>   Convert virDomainVcpuPinDefArrayFree to virDomainPinDefArrayFree
>   Convert virDomainVcpuPinDefCopy into virDomainPinDefCopy
>   Convert virDomainVcpuPinIsDuplicate into virDomainPinIsDuplicate
>   Convert virDomainVcpuPinFindByVcpu into virDomainPinFindByVcpu
>   Replace virDomainVcpuPinAdd with virDomainPinAdd
>   Replace virDomainIOThreadsPinAdd with virDomainPinAdd
>   Replace virDomainVcpuPinDel with virDomainPinDel
>   Remove virDomainIOThreadsPinDel
> 
>  src/conf/domain_conf.c   | 234 +++++++++++++++++------------------------------
>  src/conf/domain_conf.h   |  58 +++++-------
>  src/libvirt_private.syms |  16 ++--
>  src/libxl/libxl_domain.c |   2 +-
>  src/libxl/libxl_driver.c |  18 ++--
>  src/qemu/qemu_cgroup.c   |  12 +--
>  src/qemu/qemu_cgroup.h   |   4 +-
>  src/qemu/qemu_driver.c   | 104 +++++++++++----------
>  src/qemu/qemu_process.c  |  16 ++--
>  src/xen/xend_internal.c  |  10 +-
>  10 files changed, 204 insertions(+), 270 deletions(-)
> 

ACK series.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]