Re: [PATCH v4 1/7] bridge_driver: Don't access global driver randomly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 12, 2015 at 15:39:15 +0100, Michal Privoznik wrote:
> Well, network driver code has the driver accessible as a global
> variable. This makes any rework hard, as it's unclear where the
> variable is accessed and/or modified. Lets just pass the driver
> as a parameter to all functions where needed.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/network/bridge_driver.c | 430 +++++++++++++++++++++++++-------------------
>  1 file changed, 247 insertions(+), 183 deletions(-)

ACK, the renaming to network driver made it really easy to review.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]