Re: [PATCH 4/4] parallels: prevent domain define only if vcpupin is specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2015 at 23:12:22 +0300, Maxim Nestratov wrote:
> and their settings differ from common cpumask
> 
> Signed-off-by: Maxim Nestratov <mnestratov@xxxxxxxxxxxxx>
> ---
>  src/parallels/parallels_sdk.c |   14 ++++++++++++--
>  1 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
> index 4ec9161..fde908b 100644
> --- a/src/parallels/parallels_sdk.c
> +++ b/src/parallels/parallels_sdk.c
> @@ -1808,14 +1808,24 @@ prlsdkCheckUnsupportedParams(PRL_HANDLE sdkdom, virDomainDefPtr def)
>      if (def->cputune.shares ||
>          def->cputune.sharesSpecified ||
>          def->cputune.period ||
> -        def->cputune.quota ||
> -        def->cputune.nvcpupin) {
> +        def->cputune.quota) {
>  
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>                         _("cputune is not supported by parallels driver"));
>          return -1;
>      }
>  
> +    if (def->cputune.vcpupin) {
> +       for (i = 0; i < def->vcpus; i++) {

While this is still correct as the rest of the vcpupin array is filled
by the default cpu pinning mask, the rest of the cpus can be skipped.

ACK regardless.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]