Re: [PATCH 1/6] conf: Resolve Coverity RESOURCE_LEAK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2015 at 19:20:24 -0400, John Ferlan wrote:
> Commit id 'c9027d8f' added parsing of the CapNet for offload SRIOV NIC
> discovery, but forgot to free the nodes
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/conf/node_device_conf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
> index f9c9b6f..d309bc6 100644
> --- a/src/conf/node_device_conf.c
> +++ b/src/conf/node_device_conf.c
> @@ -1002,6 +1002,7 @@ virNodeDevCapNetParseXML(xmlXPathContextPtr ctxt,
>      ret = 0;

The same patch also added code that uses the @tmp variable to extract a
string via virXMLPropString and it is not freed either.

>   out:
>      ctxt->node = orignode;
> +    VIR_FREE(nodes);
>      return ret;
>  }
>  

ACK with both leaks fixed.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]