On Fri, Mar 06, 2015 at 06:53:20AM -0500, John Ferlan wrote: > > >> Yes - although based on reviews from yesterday it wasn't totally clear > >> if having a GetIOThreadPin in addition to GetIOThreadsInfo was > >> requested, so I added it to be "safe", but can remove it. > >> > >> There is a GetVcpus and a GetVcpuPinInfo and the IOThreads code mirrors > >> that. > > > > Ah that's more of a historical accident :-) We added GetVcpus first to > > simply return the number of VCPUs and later added GetVcpuPinInfo to > > return pinning info. If we were doing it fresh, we'd only add the > > GetVcpuPinInfo since it offers the superset of features. > > > > If you repost without GetIOThreadPin, I'd ack the rest. > > > > BTW, no need to repost the first 3 I already acked. > > > > OK - I'll push 1-4 since they're ACK'd (I have a related libvirt-python > patches ready too), then repost the last 5. > > Is this something that'll need adjustments in the perl bindings? (not > that I know perl all that well) Yep, every new API requires work in the perl bindings. Most people ignore it, so I end up doing the work myself, but if you fancy trying todo it I certainly wouldn't complain :-) Just let me know either way. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list