On Thu, Mar 05, 2015 at 02:59:52PM +0100, Michal Privoznik wrote: > We have something like pvpanic device. However, in some cases it does > not have any address assigned, in which case we produce this ugly XML > (still valid though): > > <devices> > <emulator>/usr/bin/qemu</emulator> > ... > <panic> > </panic> > </devices> > > Lets format "<pvpanic/>" instead. s/pvpanic/panic/ > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/conf/domain_conf.c | 20 ++++++++++----- > .../qemuxml2argv-panic-no-address.args | 5 ++++ > .../qemuxml2argv-panic-no-address.xml | 29 ++++++++++++++++++++++ > tests/qemuxml2argvtest.c | 3 +++ > tests/qemuxml2xmltest.c | 1 + > 5 files changed, 52 insertions(+), 6 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-panic-no-address.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-panic-no-address.xml > ACK Pavel -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list