Re: [PATCH v2 08/24] network_conf: Turn virNetworkObjList into virObject

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 05, 2015 at 12:05:09 +0100, Michal Privoznik wrote:
> Well, one day this will be self-locking object, but not today.
> But lets prepare the code for that! Moreover,
> virNetworkObjListFree() is no longer needed, so turn it into
> virNetworkObjListDispose().
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  cfg.mk                            |  1 -
>  src/conf/network_conf.c           | 53 +++++++++++++++++++++++++++++----------
>  src/conf/network_conf.h           | 11 ++++----
>  src/libvirt_private.syms          |  2 +-
>  src/network/bridge_driver.c       |  5 ++--
>  src/parallels/parallels_network.c |  7 +++---
>  src/test/test_driver.c            | 13 ++++------
>  7 files changed, 57 insertions(+), 35 deletions(-)

I still dislike the fact that you move the virNetworkObjTaint() function
but I don't want to waste more time on it than writing this rant.

ACK

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]