On Tue, Feb 24, 2015 at 04:34:25PM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1195660 > > There's been a bug report appearing on the qemu-devel list, that > libvirt is unable to pass spaces in disk serial number [1]. Not only > our RNG schema forbids that, the code is not prepared either. However, > with a bit of escaping (if needed) we can allow spaces there. > > 1: https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg04041.html > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > > diff to v1: > - Switch from virBufferEscapeShell to virBufferEscape > > docs/schemas/domaincommon.rng | 2 +- > src/qemu/qemu_command.c | 5 ++-- > .../qemuxml2argvdata/qemuxml2argv-disk-serial.args | 7 ++++++ > .../qemuxml2argvdata/qemuxml2argv-disk-serial.xml | 27 ++++++++++++++++++++++ > tests/qemuxml2argvtest.c | 5 ++++ > 5 files changed, 43 insertions(+), 3 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml > ACK Jan
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list