Re: [PATCH 2/2] Tests : Add test for 'ppc64le' architecture.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 04 March 2015 09:28 PM, Ján Tomko wrote:
> On Thu, Feb 26, 2015 at 10:45:54PM +0530, Prerna Saxena wrote:
>> Tests : Add test for 'ppc64le' architecture.
>>
>> Signed-off-by: Prerna Saxena <prerna@xxxxxxxxxxxxxxxxxx>
>> ---
>>  .../qemuxml2argv-pseries-cpu-le.args               |  7 +++++
>>  .../qemuxml2argv-pseries-cpu-le.xml                | 17 ++++++++++++
>>  tests/qemuxml2argvtest.c                           |  2 ++
>>  tests/testutilsqemu.c                              | 30 ++++++++++++++++++++++
>>  4 files changed, 56 insertions(+)
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-le.args
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-le.xml
>>
>> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-le.args b/tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-le.args
>> new file mode 100644
>> index 0000000..f4f8d5e
>> --- /dev/null
>> +++ b/tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-le.args
>> @@ -0,0 +1,7 @@
>> +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test \
>> +QEMU_AUDIO_DRV=none /usr/bin/qemu-system-ppc64 -S -M pseries \
>> +-m 512 -smp 1 -nographic -nodefconfig -nodefaults \
>> +-chardev socket,id=charmonitor,path=/tmp/test-monitor,server,nowait \
>> +-mon chardev=charmonitor,id=monitor,mode=readline -no-acpi -boot c -usb \
>> +-chardev pty,id=charserial0 \
>> +-device spapr-vty,chardev=charserial0,reg=0x30000000
> I don't see any reference to little endian on the command line.
>
> If the domain can only use the same endianness as the host system, do we
> need to check if the guest arch matches the host arch somewhere?
>
>
Yes, SLOF in qemu-system-ppc64 can correctly initialize KVM based on the endianness discovered for the guest, so the command line stays the same for both ppc64 & ppc64le guests.
However, we need libvirt to recognize ppc64le as a valid arch, since this is used by management utilities that depend on libvirt -- a classic example being virt-install.

Regards,

-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]