Re: [PATCH v1 24/31] bridge_driver: Use virNetworkObjEndAPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 26, 2015 at 15:17:33 +0100, Michal Privoznik wrote:
> So far, this is pure code replacement. But once we introduce
> reference counting to virNetworkObj this will be more handy as
> there'll be only one function to change: virNetworkObjEndAPI().
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/network/bridge_driver.c | 57 +++++++++++++++------------------------------
>  1 file changed, 19 insertions(+), 38 deletions(-)

In the qemu driver that is the inspiration for this change we always
pair the *EndAPI call with a  *ObjFrom* ... in this case
networkObjFromNetwork.

I'd really appreciate if you could first scrub the code base of direct
lookup and use the networkObjFromNetwork helper instead so that we can
pair every EndAPI call with that.

ACK to this patch though. If you don't fancy cleaning the existing
places that manually lookup the object I can do it. Please let me know.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]