On Thu, Feb 26, 2015 at 15:15:27 +0100, Martin Kletzander wrote:
> On Thu, Feb 26, 2015 at 01:20:29PM +0100, Martin Kletzander wrote:
> >On Wed, Feb 25, 2015 at 11:21:58AM +0100, Peter Krempa wrote:
> >>NUMA enabled guest configuration explicitly specifies memory sizes for
> >>individual nodes. Allowing the virDomainSetMemoryFlags API (and friends)
> >>to change the total doesn't make sense as the individual node configs
> >>are not updated in that case.
> >>
> >>Forbid use of the API in case NUMA is specified.
> >>---
> >>
> >>Notes:
> >> Version 2:
> >> - fixed typo in subject
> >> - fixed incomplete sentence in comment
> >> - clarified that LXC doesn't use NUMA to the extent where this change would make sense in the LXC driver
> >>
> >>src/qemu/qemu_driver.c | 10 ++++++++++
> >>1 file changed, 10 insertions(+)
> >>
> >>diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> >>index bec05d4..27cb3bf 100644
> >>--- a/src/qemu/qemu_driver.c
> >>+++ b/src/qemu/qemu_driver.c
> >>@@ -2307,6 +2307,16 @@ static int qemuDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem,
> >> if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
> >> /* Help clang 2.8 decipher the logic flow. */
> >> sa_assert(persistentDef);
> >>+
> >>+ /* resizing memory with NUMA nodes specified doesn't work as there
> >>+ * is no way to decrease the individual node sizes with this API */
> >
> >s/decrease/change/ as I believe increase isn't possible as well.
> >
> >ACK with this squashed in (or added flag that will proportionally
> >change node memory sizes):
> >
> >diff --git i/src/qemu/qemu_driver.c w/src/qemu/qemu_driver.c
> >index 471b583..60c97ad 100644
> >--- i/src/qemu/qemu_driver.c
> >+++ w/src/qemu/qemu_driver.c
> >@@ -2309,7 +2309,7 @@ static int qemuDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem,
> > sa_assert(persistentDef);
> >
> > /* resizing memory with NUMA nodes specified doesn't work as there
> >- * is no way to decrease the individual node sizes with this API */
> >+ * is no way to changee individual node sizes with this API */
>
> s/changee/change/
Pushed with the man page addition you've suggested.
Thanks.
Peter
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list