Re: [PATCH 0/3] Only talk to qemu guest agent when the domain is running

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/27/2015 08:30 AM, Ján Tomko wrote:
> Previously, only virDomainObjIsActive() was used to check domain liveness.
> This includes states like 'VIR_DOMAIN_PMSUSPENDED', where QEMU is running,
> but the guest is not.
> 
> Explicitly check the state against VIR_DOMAIN_RUNNING and refuse to
> communicate with the agent if it does not match.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=872424
> 
> Ján Tomko (3):
>   Check for qemu guest agent availability after getting the job
>   Pass virDomainObjPtr to qemuDomainAgentAvailable
>   Check if domain is running in qemuDomainAgentIsAvailable

ACK series; since it fixes a bug it is probably safe for freeze.

> 
>  src/qemu/qemu_domain.c | 11 ++++++++++-
>  src/qemu/qemu_domain.h |  2 +-
>  src/qemu/qemu_driver.c | 49 +++++++++++++++++++++++++------------------------
>  3 files changed, 36 insertions(+), 26 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]