Re: [PATCH 4/4] qemu: fix a error coverd issue in 2 place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/25/2015 10:51 PM, Ján Tomko wrote:
On Tue, Feb 24, 2015 at 01:52:08PM -0500, John Ferlan wrote:

On 02/13/2015 02:17 AM, Luyao Huang wrote:
we already set a more clearly error in networkGetNetworkAddress,
so this error will cover our error in networkGetNetworkAddress.

Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx>
---
  src/qemu/qemu_command.c | 14 ++++----------
  1 file changed, 4 insertions(+), 10 deletions(-)

I didn't check every exit patch from networkGetNetworkAddress, but
perhaps these should change to :

     if (ret < 0) {
         if (virGetLastError() == NULL)
             virReportError(VIR_ERR_XML_ERROR,...);
         goto error;
     }

Just to be sure we don't leave without setting some sort of error.
No.

All the exit paths should be checked to make sure an error was reported
in all cases where we return -1.

Okay, i have checked the code and think we will return -1 with an error setting.

So i will keep the code like this:
      if (ret < 0)
          goto error;

Thanks for your review
Jan

Luyao

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]